infra: use linter to verify no unused

allows us to build/test with unused code. lint will still fail, like we want it to
wix · Oct 12, 2021 · 81beb3a · 81beb3a
1 parent 65fb36d
commit 81beb3a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -22,6 +22,7 @@
         "plugin:@typescript-eslint/recommended-requiring-type-checking"
       ],
       "rules": {
+        "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }],
         "@typescript-eslint/ban-types": "off",
         "@typescript-eslint/explicit-module-boundary-types": "off",
         "@typescript-eslint/no-explicit-any": "off",
@@ -30,7 +31,6 @@
         "@typescript-eslint/no-unsafe-call": "off",
         "@typescript-eslint/no-unsafe-member-access": "off",
         "@typescript-eslint/no-unsafe-return": "off",
-        "@typescript-eslint/no-unused-vars": "off",
         "@typescript-eslint/no-var-requires": "off",
         "@typescript-eslint/prefer-regexp-exec": "off",
         "@typescript-eslint/restrict-plus-operands": "off",

diff --git a/packages/core/src/stylable-value-parsers.ts b/packages/core/src/stylable-value-parsers.ts
@@ -267,7 +267,7 @@ export function getNamedArgs(node: ParsedValue) {
             if (node.type === 'div') {
                 args.push([]);
             } else {
-                const { sourceIndex, ...clone } = node;
+                const { sourceIndex: _sourceIndex, ...clone } = node;
                 args[args.length - 1].push(clone);
             }
         });

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -82,8 +82,8 @@
     // "noImplicitThis": true,                           /* Enable error reporting when `this` is given the type `any`. */
     // "useUnknownInCatchVariables": true,               /* Type catch clause variables as 'unknown' instead of 'any'. */
     // "alwaysStrict": true,                             /* Ensure 'use strict' is always emitted. */
-    "noUnusedLocals": true,                              /* Enable error reporting when a local variables aren't read. */
-    "noUnusedParameters": true,                          /* Raise an error when a function parameter isn't read */
+    // "noUnusedLocals": true,                           /* Enable error reporting when a local variables aren't read. */
+    // "noUnusedParameters": true,                       /* Raise an error when a function parameter isn't read */
     // "exactOptionalPropertyTypes": true,               /* Interpret optional property types as written, rather than adding 'undefined'. */
     "noImplicitReturns": true,                           /* Enable error reporting for codepaths that do not explicitly return in a function. */
     "noFallthroughCasesInSwitch": true,                  /* Enable error reporting for fallthrough cases in switch statements. */