Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live feedback from presentation #1

Closed
qballer opened this issue Jul 11, 2017 · 0 comments
Closed

Live feedback from presentation #1

qballer opened this issue Jul 11, 2017 · 0 comments
Assignees
@barak007

Comments

@qballer
Copy link
Contributor

qballer commented Jul 11, 2017

sb seems like the wrong prefix: st, core, style, wix etc looks better.
stylesheet.context.attach is a bad name. Should be named something like renderCSS. In other words, something which implies that this is the function which renders the CSS to the DOM.

use ifndef to namespace of styleable.
AviVahl added a commit that referenced this issue May 23, 2018
@AviVahl
BREAKING: Webpack 4 support (#1)
e2d5c4f 
* BREAKING: Webpack 4 support
- usage of the new stylable webpack plugin
- initial work on production mode
- inline react-dev-utils plugins with webpack 4 support until official is upgraded.
- Upgrade all deps, including TypeScript 2.8.3.
- Remove raw css support until we research this integration better.
- Update several files to latest changes from upstream react-scripts.
- Removed ModuleScopePlugin.
- Removed test-drive-react, as we do not have tests set up yet.
- Update README of generated projects with link to official react-scripts README and stylable-specific info.
AviVahl added a commit that referenced this issue May 23, 2018
@AviVahl
BREAKING: Webpack 4 support (#1)
5d95080 
* BREAKING: Webpack 4 support
- usage of the new stylable webpack plugin
- initial work on production mode
- inline react-dev-utils plugins with webpack 4 support until official is upgraded.
- Upgrade all deps, including TypeScript 2.8.3.
- Remove raw css support until we research this integration better.
- Update several files to latest changes from upstream react-scripts.
- Removed ModuleScopePlugin.
- Removed test-drive-react, as we do not have tests set up yet.
- Update README of generated projects with link to official react-scripts README and stylable-specific info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barak007 barak007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@qballer @barak007 @arnonkehat