Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(code-formatter): Implement new code formatter #2268

Merged
merged 61 commits into from
Jan 15, 2023
Merged

feat(code-formatter): Implement new code formatter #2268

merged 61 commits into from
Jan 15, 2023

Conversation

barak007
Copy link
Collaborator

@barak007 barak007 commented Jan 17, 2022 •
edited by idoros
Loading

  • normalize all newlines
  • handle declaration value
    • normalize whitespace
    • inline and wrap value segments at default 80 characters wrapLineLength
    • prefer to wrap at current line last comma (if available)
    • if first top space contains a newline then respect source top level newlines
    • spread function arguments according to available wrapLineLength
  • handle case where decls "raws" contains comments or newlines
  • handle case where rule "raws" contains comments or newlines (not after separation ,\n)
  • handle case where at-rule "raws" contains comments or newlines
  • handle case where rule before atRule with no children
  • handle at-rule params
    • normalize all whitespace
    • format args-like body inside function()/[]/() according to indented newlines if first space includes a newline, otherwise inline
  • support new formatter in CLI
    • support --experimental for new formatter
    • support limited config: indentSize, endWithNewline, and wrapLineLength
    • documentation
  • support new formatter in language service

Unfinished in this PR

  • support existing config: newLineBetweenSelectors, newLineBetweenRulesets, and ignore

@barak007
added e2e test kit
a17c0d4
@barak007
initial one level of formatting (wip)
7bcc5d0
@barak007
start work on values
93f3125
@barak007
* support nesting indent
2b85632 
* semi colon spaces
@barak007
value foramt
25e6410
@barak007
atRules basic support
f75cebb
@barak007
add experimental flag to format-cli
9e3ece3
@barak007
handle rule separation
6ccbdc7
@barak007
refactor
51720cb
@barak007
fix refactor
f17a7cd
@barak007
handle values with spaces around
365eb7f
@barak007
fix selector indent in nested scope
f36b7d2
@barak007
preserve newline in selectors
cc698de
@barak007
refactor
8cdddce
@barak007
comments separation
1137a45
@barak007
fix commnet after comment
535bf14
@barak007
handle decl values that start with newline
8f9f953
@barak007
fix re-indent values with newlines
4a2b0fe
@barak007
* preserve groups
3422bbd 
* preserve commnets in values
@barak007
avoid running twice
1c30970
@barak007
Merge branch 'master' into barak/code-format-2
01c05a1
@barak007
Merge branch 'master' into barak/code-format-2
453020e
@barak007
fix merge
b3d844f
@idoros
Merge branch 'master' into barak/code-format-2
35376e2
@idoros
test: improve test and add issues to resolve
98fea94 
- run each test to see that the re-running the result stay the same
- added ToDos with issues or things that need to be discussed
- new test util to improve test visibility
@idoros
feat: decl value format
6375c25 
- set `wrapLineLength` option with default to 80 chars
- respect newlines if value is placed in a newline from decl prop
- respect newlines for `grid-template` props in any case
- break function arguments into newlines if there is no space for them
- limit function break if total inlined length is under 30 chars or if it has a single non function arg value
- wrap value according to available space
- lookback to previous comma to wrap from
- remove custom property final space
@idoros
chore(deps): tokey/css-value-parser@0.1.2
1dd7e10
@idoros idoros requested a review from tomrav January 5, 2023 11:28
@idoros idoros added the tooling CLI, stylable-scripts boilerplate label Jan 8, 2023
@idoros idoros merged commit b7e21fc into master Jan 15, 2023
@idoros idoros deleted the barak/code-format-2 branch January 15, 2023 09:40
@idoros idoros mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomrav tomrav Awaiting requested review from tomrav

Assignees

@idoros idoros

@barak007 barak007

Labels
tooling CLI, stylable-scripts boilerplate
Projects
Stylable
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@barak007 @AviVahl @idoros @tomrav