fix(core): st-var feature overall #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoros
added
core
- init feature in meta - move `VarSymbol` to feature - move processor code to feature - add walk return type to `analyzeSelectorNode` to alllow walk control
- add `evaluator` to `FeatureTransformContext`
- resolve local vars in feature - transform JS exports in feature - change Evaluator to stateful class to hold `tsVarOverride` data - create evaluator per transformer - remove `transformDeclarationValue` resolved data - only used by CSS custom property and already exist in data interface
- use `evaluator.evaluateValue` instead
- support inline diagnostics check for `:vars` - support inline tests for non transformed stylesheets
- add `STVar.get()` to get symbol from feature - move tests from various specs to feature - added simple missing expectations - added noticable ToDos for unexpected behavior
barak007
requested changes
Feb 7, 2022
idoros
changed the title
- previously worked in legacy `:import` while crushing in `@st-import`
- change `transformDeclarationValue` to `transformValue` - moved `Evaluator` initialization to head - changes `Evaluator` to accept optional options - add missed test for access custom value using path with errors
- change named error to be generic as it is not just used by mixins - remove symbol value mapping from st-var feature: call fields directly
- move string functions to `helpers/string` - replaced `deprecated` util with `warnOnce` from `helpers/deprecate`
barak007
approved these changes
Feb 8, 2022
- removed ToDo comment that was done - moved private the end of `transformer` head
tzachbon
pushed a commit
that referenced
this pull request
Feb 21, 2022
## fix - warn on missing arguments to `value()` function - remove outer quotes from Stylable vars JS exports - unify error when using imported class and local class - handle unknown symbol using `@st-import` - previously caused a crush ## deprecate - `meta.vars` - use `meta.getAllStVars()` or `meta.getStVar(name)` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
testStylableCoredoesn't check inline diagnostics in nodes that are removed by processorvalue()function@st-import- playgroundrefactor
analyzeSelectorNode- move definition/validation to featuretransformDeclarationValue- movevalue()transformation to featuretransformJSExports- move to featuredeprecate
meta.varstest
st-var.specand convert to new formatmove to backlog
@mediaand:vars#2318collectUrlsin analyze to run just in walk decls by removing:varsat the endst-mapandst-arrayoutput unuseful string when accessed at top level - playground