-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): implement -st-extends
parser
#2299
Conversation
code seems correct (missing the unchecked test cases that you already specified). I think you should open a new folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at the moment, left a couple of questions.
Btw, make sure to update the lock file.
import { expect } from 'chai'; | ||
import { parseCSSValue } from '@tokey/css-value-parser'; | ||
|
||
type ParsedNodes = ReturnType<typeof parseCSSValue>[number]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should export it from tokey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
public left?: string | stNode, | ||
public right?: string | stNode, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of a string, it should be the tokey ast node? (generic type for the stNode
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Just a starting point for the new
-st-extend
parsing: