feat: new cjs and esm bundles for core #2893
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two bundles to the
dist
of@stylable/core
.stylable.lib.cjs
- to be able to run in playground with commonjs module systemstylable.lib.esm
- to be able to run in browsers via importI didn't add the files anywhere in the package json just emitting the files to dist. also didn't output global iife bundle.
I removed from
enhanced-resolve
and made it mandatory to passresolveModule
to Stylable (only in the bundle). We want to remove the default resolver anyhow in the next major.I also moved
stylable-js-module-source
to core since it's the missing peace to a full transform of Stylable modules without any other packages.This adds mothing to the build time for both bundles.
we might want to consider running the entire build with esbuild.