Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: validate simple custom state template #2905

Merged
merged 2 commits into from
Oct 1, 2023
Merged

feat: validate simple custom state template #2905

merged 2 commits into from
Oct 1, 2023

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Sep 19, 2023

This PR makes sure that custom state templates are simple selectors and disallow:

  • complex selector: .x .y
  • multi-selector: .x, .y
  • invalid selector: :unclosed(
  • start with element or universal: div / *

The same validation already exist for custom state templates with param, but was delayed for the next major version.

@idoros idoros added pseudo-state Pseudo state related core Processing and transforming logic next-major Issues or PR related to the next major version labels Sep 19, 2023
@idoros idoros self-assigned this Sep 19, 2023
@idoros idoros merged commit ee072f8 into master Oct 1, 2023
18 checks passed
@idoros idoros deleted the ido/validate-template-state branch October 1, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barak007 barak007 barak007 approved these changes

Assignees

@idoros idoros

Labels
core Processing and transforming logic next-major Issues or PR related to the next major version pseudo-state Pseudo state related
Projects
Stylable
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@idoros @barak007