feat: improve namespace readability and potential optimization conflict #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- filename2varname - string2varname
- trim consequence underscores into a single "_"
- trim consequence dashes into a single "-" to prevent local delimiter ambiguity - fix tests that assumed previous behavior
idoros
added
feature
- st-namespace value is not transformed, but is validated to be a valid identifier start and also not to conflict with stylable local/state namespacing
barak007
reviewed
Nov 28, 2023
barak007
reviewed
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few improvements to the way stylesheet meta namespaces are resolved:
To mitigate potential conflicts involving the underscore character (_), which may clash with the target local delimiter, this update reduce multiple consecutive underscores into a single underscore.
Extends support for the hyphen character (-). It similarly trims consecutive hyphens to a single instance, thereby preventing issues related to state transformation conflicts. This change is particularly beneficial for handling default namespaces derived from file paths with dashes. By preserving these dashes, the resulting namespaces become more readable and accurately reflect their source file paths.
Extends support for non ASCII characters in the namespace value.
Align
@st-namespacevalidation with the allowed transformed value that is generated from a stylesheet filename.