feat(selector-parser): group nodes by compound selector #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new util to group selector parts by dom target - added new grouped_selector AST type
- new AST selector type for a list of AST that targets a DOM element - new AST type for comment with no spacing - added a bunch of type conditions to selector test-kit createNode - change groupSelectorTargets to use new CompoundSelector AST - return input selector/s with shallow grouping of compound selectors
idoros
changed the title
- shouldn't change if ast types are added
- split Immutable type for better type description (typescript output)
- changed immutable type to handle tuples better
- not just specific nth nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a new type of selector:
CompoundSelector, which represents a list of Selectors that query a single element in the DOM. And tools to group AST into the new compound selector and flatten it back (resolve #23 ).Nesting|CommentsWithSpacing|Invalid|CompoundSelector|Selector)universal | typemust only be placed as the first nodenthtypes for now)selector | compoundpseudo-elementinto a separate compound (with option to override behavior)