Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css selector immutable walk #43

Merged
merged 3 commits into from Aug 10, 2021
Merged

css selector immutable walk #43

merged 3 commits into from Aug 10, 2021

Conversation

idoros
Copy link
Collaborator

@idoros idoros commented Aug 3, 2021

Support immutable (deep readonly) AST type in walk function.

resolves #22

@idoros idoros added enhancement New feature or request css-selector-parser labels Aug 3, 2021
@idoros idoros requested a review from barak007 August 3, 2021 13:35
barak007
barak007 reviewed Aug 9, 2021
View reviewed changes
Copy link
Collaborator

@barak007 barak007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. the only thing is that we use a lot of as TYPE but I know it's a TypeScript issue

@barak007 barak007 self-requested a review August 10, 2021 08:25
@idoros idoros merged commit 39f2975 into master Aug 10, 2021
@idoros idoros deleted the ido/css-selector-immutable-walk branch August 10, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barak007 barak007 barak007 approved these changes

Assignees
No one assigned
Labels
css-selector-parser enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

readonly compatible walk
2 participants
@idoros @barak007