Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Improve Component Id and GUId handling and add RepairConditions #267

Merged
merged 2 commits into from Apr 12, 2021
Merged

Improve Component Id and GUId handling and add RepairConditions #267

merged 2 commits into from Apr 12, 2021

Conversation

robmen
Copy link
Member

@robmen robmen commented Apr 12, 2021 •
edited by rseanhall

@robmen robmen enabled auto-merge (rebase) April 12, 2021 17:20
@robmen robmen merged commit d77302d into master Apr 12, 2021
@robmen robmen deleted the rob/port-fixes branch April 12, 2021 17:24
@robmen robmen mentioned this pull request Apr 14, 2021
Merged
@rseanhall
Copy link
Contributor

As discussed here, ExePackages are not repairable without RepairArguments. RepairCondition should not be allowed there without them.

@robmen
Copy link
Member Author

robmen commented Apr 14, 2021

Yep. That check is wrapped up with the DetectCondition/Permanent check I've not settled on the final error/warnings.

@rseanhall
Copy link
Contributor

Can you disable the compilation of RepairCondition for now? You're going to have to make a commit here anyway to get an updated Core so you can build an updated Tools so you can build Bal.wixext.

@robmen
Copy link
Member Author

robmen commented Apr 14, 2021

Yeah. Next.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@robmen @rseanhall