3640 - Caching overhaul #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rseanhall
force-pushed
the
3640-no-assumption-caching
branch
from
237dca8
to
d93d3ed
Compare
robmen
reviewed
Apr 8, 2021
rseanhall
force-pushed
the
3640-no-assumption-caching
branch
from
d93d3ed
to
75080e3
Compare
Detect is supposed to be fast, so it can't fully verify every payload for every package. The engine was wasting its time by trying to verify file sizes without the hash. Even worse, it was making decisions during planning based on that insufficient verification. Contributes to #3640
Contributes to #3640 and #5253
rseanhall
force-pushed
the
3640-no-assumption-caching
branch
from
75080e3
to
b76e6da
Compare
Inactivate the engine during OnCacheAcquireBegin and Complete to allow setting the source from there. Fixes #3640 Contributes to #5253
Always send OnCacheAcquireProgress between OnCacheAcquireBegin and OnCacheAcquireComplete. Track the successful cache acquisition progress during the final progress call.
Remove the container's cache progress when reextracting Skip extracting payloads that are already cached
Add verifyStep to OnCacheVerifyProgress. Send OnContainerOrPayloadVerify events only if file existed in cache.
rseanhall
force-pushed
the
3640-no-assumption-caching
branch
from
b76e6da
to
0024ce6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wixtoolset/issues#3640
Fixes wixtoolset/issues#4758
Starts wixtoolset/issues#5253