Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark AdvtExecuteSequence warning #16

Closed
wixbot opened this issue Apr 13, 2004 · 2 comments
Closed

dark AdvtExecuteSequence warning #16

wixbot opened this issue Apr 13, 2004 · 2 comments

Comments

@wixbot
Copy link

wixbot commented Apr 13, 2004

dark provides this sort of warning:

dark.exe : decompiler warning DARK0080 :
Encountered CustomAction ‘MyFavoriteAction’ while
processing AdvtExecuteSequence. CustomActions are
not permitted in the AdvtExecuteSequence and will not
be output to decompiled source file.

This is incorrect and shouldn’t force the exclusion of
those entries. (I find a ‘decompiler’ excluding anything
like this a little strange, anyway— why can’t we
decompile anything it would know how to handle?)

You can use custom actions in the
AdvtExecuteSequence table, you just have to know
what you’re doing. As such, we need a switch to disable
this check or have it only output a warning without
excluding those entries.

Backup information indicating that careful use of
AdvtExecuteSequence isn’t always illegal:
http://msdn.microsoft.com/library/default.asp?
url=/library/en-us/msi/setup/ice72.asp

http://www.installshield.com/news/newsletter/0401-
articles/custom.asp

http://groups.google.com/groups?
threadm=ubO7VAbwCHA.2640%
40TK2MSFTNGP11&rnum=6

Originally opened by rezand from http://sourceforge.net/p/wix/bugs/11/

@wixbot
Copy link
Author

wixbot commented Sep 15, 2012

rgustin actually fixed this, but Type 19, 35, and 51
CustomActions should be preserved in the
AdvtExecuteSequence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@robmen @wixbot and others