dark /a doesn't work on orca.msi

[wixbot]

After turning on dark’s support for the /a switch, running
dark on the orca.msi from MSI 3.0 beta2 results in the
following error:

Microsoft® MSI to Wix 2.0 Decompiler Version 0.1
Copyright © Microsoft Corporation 2003. All rights
reserved.

orca.msi
dark.exe : fatal error DARK0000: Failed to get field count

Stack Trace:
at
Microsoft.Tools.WindowsInstallerXml.Msi.Record.GetFieldC
ount()
at
Microsoft.Tools.WindowsInstallerXml.Decompiler.ProcessO
therTables(Hashtable coveredTables)
at
Microsoft.Tools.WindowsInstallerXml.Decompiler.ProcessPr
oductElement(XmlWriter writer, Boolean
writeDocumentElements)
at
Microsoft.Tools.WindowsInstallerXml.Decompiler.Decompil
e(String inputPath, String outputPath)
at
Microsoft.Tools.WindowsInstallerXml.Tools.DarkMain..ctor
(String[] args)
at Microsoft.Tools.WindowsInstallerXml.Tools.Dark.Main
(String[] args)

This message happens as dark is processing the
_MergeErrors table within Orca. I’ve seen this error on a
bunch of MSI’s and will try to get more information about
it.

Originally opened by rezand from http://sourceforge.net/p/wix/bugs/20/

[wixbot]

This appeared to be just a problem with GetFieldCount having
a typo in its return test:

    public int GetFieldCount()
    {
        int size = MsiInterop.MsiRecordGetFieldCount

(this.handle);
if (0 < size)
{
throw new
System.Runtime.InteropServices.ExternalException("Failed to
get field count");
}
....
}

Should probably use "if (0 > size)" instead.

[wixbot]

GetFieldCount() in Record was confused, logic was backwards.