Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

candle: wxo contains wrong line numbers for CustomTable rows #27

Closed
wixbot opened this issue Apr 15, 2004 · 2 comments
Closed

candle: wxo contains wrong line numbers for CustomTable rows #27

wixbot opened this issue Apr 15, 2004 · 2 comments

Comments

@wixbot
Copy link

wixbot commented Apr 15, 2004

If you look at the wxo columns and rows for
CustomTable entries, you’ll notice the source line is
incorrect. It seems to be pointing to the top-level
CustomTable node for that table instead of the row/data
line in question.

I believe this just results from the lines from
ParseCustomTableElement:

foreach (XmlNode child in node.ChildNodes)
{
SourceLineNumber[] childSourceLineNumbers
= this.GetSourceLineNumbers(node);

This should probably be:

```
SourceLineNumber[] childSourceLineNumbers
```

= this.GetSourceLineNumbers(child);

Additionally, when parsing the rows in that function, it
probably should be:
case “Row”:
string dataValue = null;
int fieldCount = 0;
foreach (XmlNode data in
child.ChildNodes)
{
SourceLineNumber[]
dataSourceLineNumbers = this.GetSourceLineNumbers
(data);

Notice the “data” at the end instead.

Originally opened by rezand from http://sourceforge.net/p/wix/bugs/22/

@wixbot
Copy link
Author

wixbot commented Sep 15, 2012

Several simple cut and paste mistakes like this were fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@wixbot and others