Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot terminate processes with 0 exit code #5229

Closed
heaths opened this issue Feb 29, 2016 · 1 comment
Closed

Cannot terminate processes with 0 exit code #5229

heaths opened this issue Feb 29, 2016 · 1 comment

Comments

@heaths
Copy link

heaths commented Feb 29, 2016

  • Which version of WiX are you building with?

3.10.2

  • Which version of Visual Studio are you building with (if any)?

N/A

  • Which version of .NET are you building with?

4.6.1

  • If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?

N/A

  • Describe the problem and the steps to reproduce it.

The problem is that in the public implementation of CloseApplication with TerminateProcess, a process cannot be closed with 0. We have a couple of customers that don't want their processes to return an error if forcibly closed. The processes do not implement Restart Manager and are not Windows services, but they basically treat them like a service.

  • Describe the behavior you expected and how it differed from the actual behavior.

We want processes to be able to exit with 0. It seems the only issue is the table definition. The corresponding custom action code will work fine with 0 (defaults to it, in fact), but the UtilCompiler only sets the terminate process flag (0x20) if a value is set, which cannot be zero since minValue is 1.

@heaths
Copy link
Author

heaths commented Mar 22, 2016

Fixed

@heaths heaths closed this as completed Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants