Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WixShellExec custom action to allow parameters #5421

Open
Wiz99327 opened this issue Oct 12, 2016 · 4 comments
Open

Update WixShellExec custom action to allow parameters #5421

Wiz99327 opened this issue Oct 12, 2016 · 4 comments

Comments

@Wiz99327
Copy link

Feature requests

Currently, WixShellExec can launch an executable outside of the MSI (e.g., launching an application once it has completed the install). There may be certain situations where one or more parameters must be passed into the executable in order to launch an application.

WixShellExec does not currently support passing in parameters to an executable where necessary. The underlying code uses the ShellExecute(...) API function to launch the application, which supports passing in command line parameters. This can potentially be accomplished by setting these values in a property and then have the WixShellExec CA read in those property values (worst case scenario: the parameters property is empty and NULL is passed into ShellExecute(...), which it currently does now).

I currently implemented a carbon copy of the WixShellExec CA (and ShellExec function) to work around this limitation. It will make things easier (and thus, eliminate redundant code) if this option were implemented in WixShellExec.

@barnson barnson added this to the v4.x milestone Oct 25, 2016
@barnson
Copy link
Member

barnson commented Oct 25, 2016

We'd take this enhancement in WiX v4 if you want to submit a PR.

@bergmeister
Copy link

+1

@robmen
Copy link
Member

robmen commented Jan 4, 2018

@bergmeister, this issue is open and unassigned. That means it is waiting for someone to investigate possibilities, discuss possible solutions with the core team then implement the decided solution.

If you are interested in doing so yourself, our developer documentation provides a great checklist for getting started.

If you are not interested then you are waiting for someone else to become interested. If this issue has been open for a long time then there probably isn't much interest in this particular issue. In that case, you'll want to consider how to motivate others to fix it for you. This is a pretty good list of support options.

@bergmeister
Copy link

Thanks for the explanation. I could solve my problem in a different way at the end. But I'll have a closer look at the source code and might give it a go if it's doable in a few hours but I cannot promise anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants