Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burn should support alternate hash algorithms #6352

Closed
barnson opened this issue Feb 11, 2021 · 2 comments
Closed

Burn should support alternate hash algorithms #6352

barnson opened this issue Feb 11, 2021 · 2 comments
Labels

Comments

@barnson
Copy link
Member

barnson commented Feb 11, 2021

  • Describe the scenario and benefits that the feature supports.

Burn uses SHA-1 hashes for payload verification. IBootstrapperEngine::SetUpdate takes a BOOTSTRAPPER_UPDATE_HASH_TYPE which has only two values:

BOOTSTRAPPER_UPDATE_HASH_TYPE_NONE,
BOOTSTRAPPER_UPDATE_HASH_TYPE_SHA1,

which means that if you want to use a "better" hash algorithm, you have to pass in BOOTSTRAPPER_UPDATE_HASH_TYPE_NONE and get no hash checking whatsoever.

  • Describe how you're accomplishing the feature today (if possible).

Not.

  • Describe what you'd like the new feature to do.

All the underlying hash checking Burn uses support whatever Windows supports. Burn shouldn't be so restrictive. Alternatively, it should switch to SHA-256 to a get "modern" algorithm.

@barnson barnson added the triage label Feb 11, 2021
@rseanhall
Copy link
Contributor

I was expecting to do this as part of #3992 - replacing SHA1 with SHA512.

@barnson
Copy link
Member Author

barnson commented Feb 11, 2021

Yeah, that's the "at least" scenario.

@barnson barnson added burn and removed triage labels Feb 18, 2021
@barnson barnson closed this as completed Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants