Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Burn's SetVariable so that it can evaluate a formatted string #6724

Closed
rseanhall opened this issue Feb 9, 2022 · 0 comments · Fixed by wixtoolset/wix#125
Closed
Assignees
Labels
Milestone

Comments

@rseanhall
Copy link
Contributor

Feature requests

If this issue is a feature request:

  • Describe the scenario and benefits that the feature supports.

SetVariable was added in v4, but it only can set a variable to a static value. The analogous SetProperty in MSI evaluates the string so SetVariable should be able to do this, too. This would help when getting a version string from the registry and coercing it to a version to use Burn's version comparisons.

  • Describe how you're accomplishing the feature today (if possible).

Custom code in the BA.

  • Describe what you'd like the new feature to do.

Change the existing Type attribute so that the source value has a type (SourceType?) and the target variable has a type (keep Type or TargetType?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants