Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wix 4 Rc2: Better error message if directory for HarvestDirectory cannot be found #7211

Open
ChristianSauer opened this issue Feb 8, 2023 · 1 comment
Labels
enhancement heat up for grabs No one volunteered to fix the issue. If you are interested, comment with "I want to fix this issue"

Comments

@ChristianSauer
Copy link

Feature requests

I have a HarvestDirectory Item on my WixProj like this:

 <ItemGroup>
        <HarvestDirectory Include="..\Release\SomeRelease">
            <DirectoryRefId>INSTALLFOLDER</DirectoryRefId>
            <PreprocessorVariable>var.HarvestPath</PreprocessorVariable>
            <ComponentGroupName>SomeFiles</ComponentGroupName>
            <AutogenerateGuids>true</AutogenerateGuids>
            <SuppressRegistry>true</SuppressRegistry>
            <SuppressFragments>true</SuppressFragments>
            <SuppressCom>true</SuppressCom>
            <SuppressRootDirectory>true</SuppressRootDirectory>
        </HarvestDirectory>
    </ItemGroup>

When the directory does not exist Wix fails with this message:

  My.wxs(7): [WIX0094] The identifier 'WixComponentGroup:SomeFiles' could not be found. Ensure you have typed the reference correctly and that all the necessary inputs are provided to the linker.

This message is less than helpful. It would be great if the error directly mentions that the Directory does not exist.
The problem is not even in the log, so finding this issue is annopying.

@barnson barnson added enhancement heat up for grabs No one volunteered to fix the issue. If you are interested, comment with "I want to fix this issue" and removed triage labels Feb 9, 2023
@BryanCrotaz
Copy link

I've had a (brief) conversation about this #7806 (comment) with @robmen and my suggestion was:

  • Directory doesn't exist: Log error and fail the build - the task can't do what I asked, so the fault is mine
  • Directory is empty: Log warning and generate empty component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement heat up for grabs No one volunteered to fix the issue. If you are interested, comment with "I want to fix this issue"
Projects
None yet
Development

No branches or pull requests

3 participants