Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma in folder or file name of wixproj cause build error: [MSBuild]::MakeRelative #7343

Closed
wmanning opened this issue Mar 31, 2023 · 0 comments · Fixed by wixtoolset/wix#389
Assignees
Labels
Projects
Milestone

Comments

@wmanning
Copy link

wmanning commented Mar 31, 2023

Bugs

If this issue is a bug:

  • Which version of WiX are you building with?

v4.0-rc.4

  • Which version of Visual Studio are you building with (if any)?

Visual Studio 2019

  • Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?

Heatwave 0.9.6

  • Which version of .NET are you building with?

(.NET version)

  • If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?

Windows 10 Pro

  • Describe the problem and the steps to reproduce it.

If I have commas in the file path or file name I get the following error during build:

C:\Users\Wesley.Manning.nuget\packages\wixtoolset.sdk\4.0.0-rc.4\tools\wix.targets(907,22): error MSB4186: Invalid static method invocation syntax: "[MSBuild]::MakeRelative($(FullIntermediateOutputPat
h), C:\Users\me\Github\project\msiWDriver_Win8,8.1,10_x64\obj\Release\STMicro DFU 64bit Drivers - Windows 8_8.1_10.msi)". Method '[MSBuild]::MakeRelative' not found. Static method invoc
ation should be of the form: $([FullTypeName]::Method()), e.g. $([System.IO.Path]::Combine(a, b)). Check that all parameters are defined, are of the correct type, and are specified in the right order

If I remove the comma from msiWDriver_Win8,8.1,10_x64, the build error goes away.

  • Describe the behavior you expected and how it differed from the actual behavior.

No build errors with commas in names of directories or files.

Similar issue discussed here:
dotnet/aspnetcore#31770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
wix-4.0.0
Awaiting triage
Development

Successfully merging a pull request may close this issue.

3 participants