Consider Ref suffix for more attributes

[barnson]

• Describe the scenario and benefits that the feature supports.

A change we made in the WiX v4 language was to consistently use -Ref for attributes that referenced another entity where then they were inconsistent (e.g., BinaryKey). Other attributes are also references but lack any suffix (e.g., Component/@Directory).

• Describe how you're accomplishing the feature today (if possible).

n/a

• Describe what you'd like the new feature to do.

Discuss whether this is actually a good idea.

[chrpai]

MSI uses Table_ In WiX, is there a difference between ElementName(Ref) and Attribute(Ref). If they both cause the compiler to search for fragments then I like Ref in the attribute name. If they don't then I don't like Ref in the Attribute name. Pick a different word suffix.

[BMurri]

BinaryKey refers to Binary/@key, correct?

An attribute that points to Directory/@id should then be DirectoryId, not DirectoryRef, if you are looking for consistency.

Or, use Ref consistently.

In the case of things like Shortcut, prefix "Directory" with the role that reference has in the shortcut (so, WorkingDirectoryId or WorkingDirectoryRef). That way, there's both consistency and elimination of ambiguity.