Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate component id when there is no valid keypath #7695

Open
barnson opened this issue Aug 27, 2023 · 0 comments
Open

Generate component id when there is no valid keypath #7695

barnson opened this issue Aug 27, 2023 · 0 comments
Assignees
Labels

Comments

@barnson
Copy link
Member

barnson commented Aug 27, 2023

  • Describe the scenario and benefits that the feature supports.

WiX v4 defaults the component id to the id of the keypath. (This is consistent with v3 behavior but a bit odd given that File/@Id no longer defaults to the source name.) But when a component doesn't follow the rules for a generated guid, there is also no default id and error occurs. An id should be generated like every other id.

  • Describe how you're accomplishing the feature today (if possible).

Manual ids.

  • Describe what you'd like the new feature to do.

Generate ids...and consider whether WiX v6 should kill off the "default component id is keypath id" behavior and always generate one by default.

@barnson barnson added the triage label Aug 27, 2023
@barnson barnson added up for grabs No one volunteered to fix the issue. If you are interested, comment with "I want to fix this issue" and removed triage labels Sep 5, 2023
@barnson barnson changed the title Generate component id Generate component id when there is no valid keypath Sep 5, 2023
@barnson barnson added compiler and removed up for grabs No one volunteered to fix the issue. If you are interested, comment with "I want to fix this issue" labels Sep 5, 2023
@barnson barnson self-assigned this Sep 5, 2023
@barnson barnson modified the milestone: v5.0.0-preview.1 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant