Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiX v4 - Directory Table Primary Key conflict #7767

Closed
chrpai opened this issue Oct 3, 2023 · 7 comments
Closed

WiX v4 - Directory Table Primary Key conflict #7767

chrpai opened this issue Oct 3, 2023 · 7 comments
Assignees
Labels
Milestone

Comments

@chrpai
Copy link

chrpai commented Oct 3, 2023

  • Which version of WiX are you building with?

wixtoolset.sdk/4.0.2

  • Which version of Visual Studio are you building with (if any)?

17.7.3

  • Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?

Heatwave v1.0.1

  • Describe the problem and the steps to reproduce it.

The following WiX XML throws error:

WIX0130	The primary key 'dL1NZp0hsYuozrtgoeU55Nn66GRE' is duplicated in table 'Directory'. Please remove one of the entries or rename a part of the primary key to avoid the collision.
<?xml version="1.0" encoding="utf-8"?>
<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
  <Fragment>
    <ComponentGroup Id="OneSupportProtocolHandlerFiles">
      <Component Directory="INSTALLLOCATION" Subdirectory="Packages\SCCMRemote2012\00000409">
        <File Source="$(var.SourceDir)\Packages\SCCMRemote2012\00000409\srvmsgs.dll" KeyPath="yes" />
      </Component>
      <Component Directory="INSTALLLOCATION" Subdirectory="Packages\SCCMRemote2012">
        <File Source="$(var.SourceDir)\Packages\SCCMRemote2012\CmRcViewer.exe" KeyPath="yes" />
      </Component>
    </ComponentGroup>
  </Fragment>
</Wix>

INSTALLLOCATION is defined as below and is being built x64 platform.

<StandardDirectory Id="ProgramFiles6432Folder">
  <Directory Id="CompanyFolder" Name="THD">
    <Directory Id="INSTALLLOCATION" Name="OneSupportProtocolHandler">
    </Directory>
  </Directory>
</StandardDirectory>
  • Describe the behavior you expected and how it differed from the actual behavior.

I should be able to add both components without getting a duplicate generated directory table id.

@chrpai chrpai added the triage label Oct 3, 2023
@barnson barnson added binder and removed triage labels Oct 17, 2023
@barnson barnson added this to the v5.0.0-preview.1 milestone Oct 17, 2023
@chrpai
Copy link
Author

chrpai commented Oct 17, 2023

Is there any chance this will make it into a 4.0.x? This new feature is central to IsWiX not requiring merge modules for authoring anymore. @robmen

@robmen
Copy link
Member

robmen commented Oct 26, 2023

There are no plans for another v4 release, but it is always possible.

@robmen
Copy link
Member

robmen commented Nov 1, 2023

I can believe this could happen but I do not reproduce the problem with the provided snippets. Can you please provide a full .wxs file that reproduces the problem?

@chrpai
Copy link
Author

chrpai commented Nov 1, 2023

This is really wierd... I can't reproduce it anymore either. I remember this error... I copy and pasted the generated Id in the error message and isolated 2 components that conflicted out of all the other components. At the time I worked around it by deploying the files to a shorter path. I can see that commit in my repos history. I made a branch off of the SHA that had the problem and it builds just fine now. The only difference I can see is I'm now on 17.7.4 instead of 17.7.3.

@robmen
Copy link
Member

robmen commented Nov 4, 2023

Bummer. There is going to be a v4.0.3 very soon and I'd like to get a fix for this issue in it but I've not been able to reproduce the problem.

@chrpai
Copy link
Author

chrpai commented Nov 6, 2023

Challenge accepted. I will try to stress the hell out of wix and see if I can repro it. Personally, I'm wondering if something in .NET was causing it and was fixed.

@chrpai
Copy link
Author

chrpai commented Nov 6, 2023

I can't reproduce. Closing.

@chrpai chrpai closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants