Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Dll's Excluded During Creation of Custom Action Dll #7836

Open
claybrooks opened this issue Nov 5, 2023 · 0 comments
Open

Native Dll's Excluded During Creation of Custom Action Dll #7836

claybrooks opened this issue Nov 5, 2023 · 0 comments
Labels
up for grabs No one volunteered to fix the issue. If you are interested, comment with "I want to fix this issue"

Comments

@claybrooks
Copy link

claybrooks commented Nov 5, 2023

  • Which version of WiX are you building with?

4.0.2

  • Which version of Visual Studio are you building with (if any)?

Visual Studio 2022 version 17.7.6

  • Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?

N/A

  • Which version of .NET are you building with?

.NET Framework 4.8

  • If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?

Windows Server 2019

  • Describe the problem and the steps to reproduce it.

I am developing a managed custom action. The custom action (and entirety of my repo) uses Nuget Package Reference. One of my nugets includes a dependency on Microsoft.Data.SqlClient.SNI.x86.dll. Microsoft.Data.SqlClient.SNI.x86.dll is a native dll and is not getting packaged when the .CA.dll is produced.

In order to work around this issue, I've copied Microsoft.Data.SqlClient.SNI.x86.dll to a separate location in my repo and added it as a content file with "Copy Always" enabled to my custom action project. This seems to get it packaged with the installer.

  • Describe the behavior you expected and how it differed from the actual behavior.

I would expect all necessary dlls to be included in the final .msi package. It seems like MSBUILD with Nuget Package Reference has problems with bringing along transitive dependencies that are native dlls as discussed here.

@barnson barnson added up for grabs No one volunteered to fix the issue. If you are interested, comment with "I want to fix this issue" and removed triage labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up for grabs No one volunteered to fix the issue. If you are interested, comment with "I want to fix this issue"
Projects
None yet
Development

No branches or pull requests

2 participants