Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codepage not set in creating msi database #8

Closed
wixbot opened this issue Apr 8, 2004 · 5 comments
Closed

Codepage not set in creating msi database #8

wixbot opened this issue Apr 8, 2004 · 5 comments
Labels

Comments

@wixbot
Copy link

wixbot commented Apr 8, 2004

Constructor of Output class does not copy the
codepage value of the entrySection, so
output.codepage remains 0.

As a result the codepage on the MsiDatabase will never
be set. This will (at least) mess up the UI for any non-
ASCII characters.

fix:
internal Output(Section entrySection) :
this()
{
this.entrySection = entrySection;
this.sections = new SectionCollection();
this.codepage = entrySection.codepage;

}

or see attached patch.

B.T.W. Very good stuff and many thanks for publishing
on sourceforge.

Originally opened by schuur from http://sourceforge.net/p/wix/bugs/4/

@wixbot
Copy link
Author

wixbot commented Sep 15, 2012

kijk, met locale 1043 komt 't wel goed ;)

@wixbot
Copy link
Author

wixbot commented Sep 15, 2012

Thanks! This will go on my rapidly growing list of little fixes I
will commit as soon as Rob sorts out the admin stuff. If
there's one thing that cannot be tested/verified/developed
enough, it's internationalization (trust me, I know -- look at
my name and take a wild guess).

Oh, enneuh... bedankt he! :-)

@wixbot
Copy link
Author

wixbot commented Sep 15, 2012

The patch file

@wixbot
Copy link
Author

wixbot commented Sep 15, 2012

I do not believe this is the end of the codepage bugs, but it
definitely is moving in the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants
@wixbot and others