Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wix v4 convert fails with File elements with only an Id attribute #8148

Open
1 task done
tjlakixi opened this issue Apr 18, 2024 · 0 comments
Open
1 task done

Wix v4 convert fails with File elements with only an Id attribute #8148

tjlakixi opened this issue Apr 18, 2024 · 0 comments
Labels
up for grabs No one volunteered to fix the issue. If you are interested, comment with "I want to fix this issue" wixcop

Comments

@tjlakixi
Copy link

tjlakixi commented Apr 18, 2024

WiX Version

5.0.0

.NET or MSBuild or Visual Studio Version

VS 2022

HeatWave Version

1.0.4.5

Windows Version

Win11 23H2

Repro Repo

No response

Repro Steps

  1. Have a Wix v3 wixproj with a wxs with a Component with a File with an @Id attribute only:
<Component>
	<File Id="MyFile.dll" />
</Component>
  1. Notice that it builds/compiles fine. The file name is taken from the id.
  2. Run wix convert (using FireGiant HeatWave Community Edition)
  3. Notice that the conversion succeeded with no errors
  4. Try to build the wixproj

Actual Result

The component has not been converted, it is the same as before conversion:

<Component>
	<File Id="MyFile.dll" />
</Component>

But the compiler spits out an error:
error WIX0010: The File/@Name attribute was not found; it is required.

Expected Result

Either: like in v3, the @Name attribute is not required and defaults to value of @Id:

default value is ... the value of the Id attribute, if the Source attribute is omitted or doesn't contain a file name.

Or, if that v3 rule will never be valid anymore: the wix convert process should add an @Name attribute and remove @Id.

Acknowledgements

  • I acknowledge that this is a fully completed bug report. It is not a question or attempt to get help debugging my issue (because those should be sent to Discussions).
@barnson barnson added wixcop up for grabs No one volunteered to fix the issue. If you are interested, comment with "I want to fix this issue" and removed triage labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
up for grabs No one volunteered to fix the issue. If you are interested, comment with "I want to fix this issue" wixcop
Projects
None yet
Development

No branches or pull requests

2 participants