3421 - Reinstall packages that were uninstalled during failed upgrade bundle #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rseanhall
commented
Nov 17, 2021
There was a problem hiding this comment.
As we discussed in meeting 217, the plan was to automatically trigger a normal install operation for the older bundle on rollback of an upgrade. Unfortunately, things aren't that black and white for Burn. I had to make Burn install all upgrade related bundles at the end of rollback regardless of which packages were executed for the following reasons:
| @@ -1487,6 +1524,39 @@ extern "C" HRESULT PlanRelatedBundlesComplete( | |||
| hr = DependencyPlanPackageComplete(&pRelatedBundle->package, pPlan); | |||
| ExitOnFailure(hr, "Failed to complete plan dependency actions for related bundle package: %ls", pRelatedBundle->package.sczId); | |||
| } | |||
|
|
|||
| if (fInstallingAnyPackage && BOOTSTRAPPER_RELATION_UPGRADE == pRelatedBundle->relationType) | |||
There was a problem hiding this comment.
- There is no concept of "the older bundle", one bundle could have multiple bundles to uninstall as part of the Update related bundle behavior.
| @@ -1487,6 +1524,39 @@ extern "C" HRESULT PlanRelatedBundlesComplete( | |||
| hr = DependencyPlanPackageComplete(&pRelatedBundle->package, pPlan); | |||
| ExitOnFailure(hr, "Failed to complete plan dependency actions for related bundle package: %ls", pRelatedBundle->package.sczId); | |||
| } | |||
|
|
|||
| if (fInstallingAnyPackage && BOOTSTRAPPER_RELATION_UPGRADE == pRelatedBundle->relationType) | |||
There was a problem hiding this comment.
- As you can probably see from the first commit, I was planning on using the operation to only select MajorUpgrade bundles. But some bundles could support downgrading, so the bundle to install is actually newer and would have been labeled as Downgrade.
src/burn/engine/apply.cpp
Outdated
| @@ -739,6 +744,9 @@ extern "C" HRESULT ApplyExecute( | |||
| IgnoreRollbackError(hrRollback, "Failed rollback actions"); | |||
| } | |||
|
|
|||
| hrRollback = DoRestoreRelatedBundleActions(pEngineState, &context, pRestart); | |||
There was a problem hiding this comment.
- Identifying which upgrade bundle was responsible for each MSI that was uninstalled is not always possible. Another wrinkle here is that Exe packages could also be breaking things that the older bundles needs to repair.
rseanhall
force-pushed
the
3421-restore-upgrade-bundle
branch
from
0cef774
to
192c318
Compare
|
The Appveyor build was successful: https://ci.appveyor.com/project/wixtoolset/wix4/builds/42532091. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rolling back a bundle failure, reinstall all upgrade related bundles.
Fixes wixtoolset/issues#3421
wixtoolset/issues#5796