Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some memory leaks in the engine. #118

Merged
merged 1 commit into from Jul 19, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions History.md
@@ -1,3 +1,5 @@
* jchoover: Fixed some memory leaks in the engine.

* BobArnson: WIXBUG:4466 - Open icons with read-sharing in DTF.

* BobArnson: WIXBUG:4476 - Add x64 deputil.lib to NativeSdkMsi.
Expand Down
1 change: 1 addition & 0 deletions src/burn/engine/container.cpp
Expand Up @@ -160,6 +160,7 @@ extern "C" void ContainersUninitialize(
ReleaseStr(pContainer->sczHash);
ReleaseStr(pContainer->sczSourcePath);
ReleaseStr(pContainer->sczFilePath);
ReleaseMem(pContainer->pbHash);
ReleaseStr(pContainer->downloadSource.sczUrl);
ReleaseStr(pContainer->downloadSource.sczUser);
ReleaseStr(pContainer->downloadSource.sczPassword);
Expand Down
2 changes: 2 additions & 0 deletions src/burn/engine/engine.cpp
Expand Up @@ -301,6 +301,8 @@ static void UninitializeEngineState(
PackagesUninitialize(&pEngineState->packages);
CatalogUninitialize(&pEngineState->catalogs);
SectionUninitialize(&pEngineState->section);
ContainersUninitialize(&pEngineState->containers);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We went through the trouble of creating it but never called it. Nice.


ReleaseStr(pEngineState->command.wzLayoutDirectory);
ReleaseStr(pEngineState->command.wzCommandLine);

Expand Down
2 changes: 2 additions & 0 deletions src/libs/dutil/polcutil.cpp
Expand Up @@ -116,5 +116,7 @@ static HRESULT OpenPolicyKey(
ExitOnFailure(hr, "Failed to open policy registry key.");

LExit:
ReleaseStr(sczPath);

return hr;
}