Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readme so GitHub will stop telling us we should have a readme #2

Merged
merged 2 commits into from Mar 15, 2014
Merged

Add readme so GitHub will stop telling us we should have a readme #2

merged 2 commits into from Mar 15, 2014

Conversation

barnson
Copy link
Member

@barnson barnson commented Mar 15, 2014

Minor rewrite of what's on the Codeplex home page, with a couple of new links.

@robmen
Copy link
Member

robmen commented Mar 15, 2014

Wow, that was quick turn around. Awesome.

@robmen robmen closed this Mar 15, 2014
@barnson
Copy link
Member Author

barnson commented Mar 15, 2014

Did you merge it? It's not showing up at https://github.com/wixtoolset/wix3 and GitHub says "closed with unmerged commits."

@robmen
Copy link
Member

robmen commented Mar 15, 2014

I hit the merge button. :/ I then closed it. Maybe that messes things up?

From: Bob Arnsonmailto:notifications@github.com
Sent: ý3/ý14/ý2014 22:39
To: wixtoolset/wix3mailto:wix3@noreply.github.com
Cc: Rob Menschingmailto:rob@robmensching.com
Subject: Re: [wix3] Add readme so GitHub will stop telling us we should have a readme (#2)

Did you merge it? It's not showing up at https://github.com/wixtoolset/wix3 and GitHub says "closed with unmerged commits."

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-37718044.

@barnson
Copy link
Member Author

barnson commented Mar 15, 2014

Let's see what this button (Reopen) does...

@barnson barnson reopened this Mar 15, 2014
barnson added a commit that referenced this pull request Mar 15, 2014
@barnson
Merge pull request #2 from barnson/readme
c8be3d4 
Add readme so GitHub will stop telling us we should have a readme
@barnson barnson merged commit c8be3d4 into wixtoolset:develop Mar 15, 2014
@barnson barnson deleted the readme branch March 15, 2014 05:44
@barnson
Copy link
Member Author

barnson commented Mar 15, 2014

That worked.

barnson pushed a commit that referenced this pull request Mar 6, 2017
@jabo2 @barnson
util:InternetShortcut needs Icon #3163 (#2)
be0abc8 
* util:InternetShortcut needs Icon #3163

* util:InternetShortcut needs Icon #3163

* util:InternetShortcut needs Icon #3163

* util:InternetShortcut needs Icon #3163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@barnson @robmen