New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ExePackage/CommandLine. #238

Merged
merged 3 commits into from Apr 25, 2015

Conversation

Projects
None yet
3 participants
@barnson
Member

barnson commented Apr 20, 2015

  • Add WixBundleExecutePackageAction variable: Set to the BOOTSTRAPPER_ACTION_STATE of the package as it's about to executed.
  • Add ExePackage/CommandLine to compiler and binder.
  • Update Burn to parse CommandLine table in manifest and apply it during ExePackage execution.

barnson added some commits Apr 20, 2015

Squashed commit of the following:
commit b0fdb29
Merge: 8557187 a2cfba8
Author: Rob Mensching <rob@robmensching.com>
Date:   Fri Apr 17 17:00:15 2015 -0700

    Merge pull request #3 from firegiant/ExePackageCommandLine

    Implement ExePackage/CommandLine.

commit a2cfba8
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Apr 17 18:05:39 2015 -0400

    Re-address review feedback.

commit 3595f70
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Apr 16 17:46:12 2015 -0400

    Address review feedback.

commit 3af9028
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed Apr 1 20:25:53 2015 -0400

    Implement ExePackage/CommandLine.

    - Add WixBundleExecutePackageAction variable: Set to the BOOTSTRAPPER_ACTION_STATE of the package as it's about to executed.
    - Add ExePackage/CommandLine to compiler and binder.
    - Update Burn to parse CommandLine table in manifest and apply it during ExePackage execution.
DWORD cNodes = 0;
LPWSTR scz = NULL;
// select exit code nodes

This comment has been minimized.

@rseanhall

rseanhall Apr 21, 2015

Member

The WiX style is for comments to be complete sentences, so they should always be capitalized and have periods.

@rseanhall

rseanhall Apr 21, 2015

Member

The WiX style is for comments to be complete sentences, so they should always be capitalized and have periods.

}
// build command
if (wzArguments && *wzArguments)
if (0 < lstrlenW(sczArguments))

This comment has been minimized.

@rseanhall

rseanhall Apr 21, 2015

Member

Why can't we use if (*sczArguments)?

@rseanhall

rseanhall Apr 21, 2015

Member

Why can't we use if (*sczArguments)?

This comment has been minimized.

@barnson

barnson Apr 23, 2015

Member

It might be an empty string.

@barnson

barnson Apr 23, 2015

Member

It might be an empty string.

/// <summary>
/// Utility class for Burn CommandLine information.
/// </summary>
internal class CommandLineInfo

This comment has been minimized.

@rseanhall

rseanhall Apr 21, 2015

Member

Creating new Info classes makes me sad.

@rseanhall

rseanhall Apr 21, 2015

Member

Creating new Info classes makes me sad.

This comment has been minimized.

@barnson

barnson Apr 23, 2015

Member

Mission accomplished. :) Fair point but it turns out there are few *Row classes to model. I thought I had one with WixApprovedExeForElevationRow but then I found ApprovedExeForElevation. :)

@barnson

barnson Apr 23, 2015

Member

Mission accomplished. :) Fair point but it turns out there are few *Row classes to model. I thought I had one with WixApprovedExeForElevationRow but then I found ApprovedExeForElevation. :)

@robmen robmen merged commit 3eea1e8 into wixtoolset:develop Apr 25, 2015

robmen added a commit that referenced this pull request Apr 25, 2015

@barnson barnson deleted the barnson:feat4719 branch May 8, 2015

@barnson barnson restored the barnson:feat4719 branch Feb 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment