Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ExePackage/CommandLine. #238

Merged
merged 3 commits into from Apr 25, 2015
Merged

Implement ExePackage/CommandLine. #238

merged 3 commits into from Apr 25, 2015

Conversation

barnson
Copy link
Member

@barnson barnson commented Apr 20, 2015

  • Add WixBundleExecutePackageAction variable: Set to the BOOTSTRAPPER_ACTION_STATE of the package as it's about to executed.
  • Add ExePackage/CommandLine to compiler and binder.
  • Update Burn to parse CommandLine table in manifest and apply it during ExePackage execution.

@barnson
Squashed commit of the following:
c50afbc 
commit b0fdb29
Merge: 8557187 a2cfba8
Author: Rob Mensching <rob@robmensching.com>
Date:   Fri Apr 17 17:00:15 2015 -0700

    Merge pull request wixtoolset#3 from firegiant/ExePackageCommandLine

    Implement ExePackage/CommandLine.

commit a2cfba8
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Apr 17 18:05:39 2015 -0400

    Re-address review feedback.

commit 3595f70
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Apr 16 17:46:12 2015 -0400

    Address review feedback.

commit 3af9028
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed Apr 1 20:25:53 2015 -0400

    Implement ExePackage/CommandLine.

    - Add WixBundleExecutePackageAction variable: Set to the BOOTSTRAPPER_ACTION_STATE of the package as it's about to executed.
    - Add ExePackage/CommandLine to compiler and binder.
    - Update Burn to parse CommandLine table in manifest and apply it during ExePackage execution.
@barnson
Add History.md entry.
d391bf2
rseanhall
rseanhall reviewed Apr 21, 2015
View reviewed changes
src/burn/engine/exeengine.cpp
@@ -25,7 +25,7 @@ static HRESULT HandleExitCode(

// function definitions

extern "C" HRESULT ExeEngineParsePackageFromXml(
static HRESULT ParseExitCodesFromXml(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static methods don't belong up here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate making the compiler's job easier by duplicating declarations.

@robmen robmen merged commit 3eea1e8 into wixtoolset:develop Apr 25, 2015
robmen added a commit that referenced this pull request Apr 25, 2015
@robmen
Merge pull request #238 from barnson/feat4719
349eb76 
Conflicts:
	History.md
@barnson barnson deleted the feat4719 branch May 8, 2015 04:03
@barnson barnson restored the feat4719 branch February 12, 2017 21:20
@rseanhall rseanhall mentioned this pull request Jan 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@barnson @rseanhall @robmen