New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIXBUG:4499 - Bind MBApreq language to correct langid #275
Conversation
history/4499.md
Outdated
@@ -0,0 +1 @@ | |||
* BMurri: WIXBUG:4499 - Bind MBApreq language to correct langid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current approach is old, but not incorrect. You need different naming and descriptions, like UseUILanguages
or such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite the name, GetUserDefaultLangID gets the language of the installed OS, not of the user. It has never gotten the "user" language as far as I've been able to determine. http://blogs.msdn.com/b/heaths/archive/2005/02/17/375830.aspx.
Please tell me naming and descriptions that are more useful without being incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct is not viable. I recommended one alternative: UseUILanguages
Addressed and squished. |
@BMurri now that we've moved to .NET Foundation, can you sign the .NET Foundation CLA? http://wixtoolset.org/development/assignment-agreement/ |
@BMurri, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
This is a WiX 3.x only implementation, making fixing the code that determines the user's locale an opt-in (if you don't opt-in, you retain the current behavior). There is a separate implementation in another pull request for 4.0 which doesn't require opting into correct behavior.