New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ISO/IEC 19770-2:2105 (aka SWID Tags-2) #292

Merged
merged 0 commits into from Aug 25, 2015

Conversation

Projects
None yet
3 participants
@firegiantco

firegiantco commented Aug 25, 2015

No description provided.

</xs:annotation>
</xs:attribute>
<xs:attribute name="Type" type="TagTypeUnion">

This comment has been minimized.

@barnson

barnson Aug 25, 2015

Member

Why leave Licensed but remove Type?

@barnson

barnson Aug 25, 2015

Member

Why leave Licensed but remove Type?

This comment has been minimized.

@firegiantco

firegiantco Aug 25, 2015

Type is still present. Its type was changed to string (to be allowed to remove the union) and marked deprecated. Just like Licensed.

@firegiantco

firegiantco Aug 25, 2015

Type is still present. Its type was changed to string (to be allowed to remove the union) and marked deprecated. Just like Licensed.

DWORD cDeletedDirs = 0;
LPWSTR sczPath = NULL;
while (wzPath && *wzPath && ::RemoveDirectoryW(wzPath))

This comment has been minimized.

@jchoover

jchoover Aug 25, 2015

Contributor

Does it make since to at least log result from GetLastError if RemoveDirectoryFails for any error other than an expected error?

https://msdn.microsoft.com/en-us/library/windows/desktop/aa365488(v=vs.85).aspx

I see info about ReadOnly directoriey attributes, as well as crazyness with junction points/ sym links.

@jchoover

jchoover Aug 25, 2015

Contributor

Does it make since to at least log result from GetLastError if RemoveDirectoryFails for any error other than an expected error?

https://msdn.microsoft.com/en-us/library/windows/desktop/aa365488(v=vs.85).aspx

I see info about ReadOnly directoriey attributes, as well as crazyness with junction points/ sym links.

@barnson barnson merged commit c535cc8 into wixtoolset:develop Aug 25, 2015

@robmen robmen deleted the firegiant:4867-swidtag2 branch Aug 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment