New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added description for ERROR_FAIL_NOACTION_REBOOT on Windows XP #310
Added description for ERROR_FAIL_NOACTION_REBOOT on Windows XP #310
Conversation
3401b6f
to
48733a3
Compare
Or let's add to dutil (or burn) own string resources with different translations of the error. |
As I mentioned in wixtoolset/issues#4933, I think this should go into WixStdBA, not StrUtil. What do you think? |
Are you offer to add in wixstdba.rc string resources (localized) for ERROR_FAIL_NOACTION_REBOOT, and in WixStandardBootstrapperApplication.cpp check if StrAllocFromError returns nothing for ERROR_FAIL_NOACTION_REBOOT and load the description from own resources? The better solution,i think is add to all standard themes (wxl- files) and load ERROR_FAIL_NOACTION_REBOOT description from corresponding wxl-file for any OS version (via LocLocalizeString())? |
We don't have localization strings for WixStdBA other than the base English strings, so we need to fall back to OS-provided strings whenever they're available. |
There are no corresponding descriptions for ERROR_FAIL_NOACTION REBOOT on Windows XP. Therefore we need add them manually anywhere in WixStdBA.
First way is standard for Windows apps. What do you think about it? |
We've moved to the .NET Foundation, but we're having trouble getting the bot to check older pull requests. Here's what it would normally say: Hi @PavelAnfimov, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org. TTYL, DNFBOT; |
@PavelAnfimov, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Implemented in #413. |
Ticket here
Since dutil does not have own string resources (to add them for only this would be a big overhead), let's add at least an English description of the error. That will help many of users to undrestand situation.