New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When elevated place clean room in system Temp folder #456

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Projects
None yet
4 participants
@robmen
Member

robmen commented Nov 15, 2017

To prevent DLL hijacking the clean room process when launched elevated,
the system Temp folder will be used instead of the user's temp folder.
This ensures the user cannot slip malicious DLLs into the clean room.

Fixes wixtoolset/issues#5724

When elevated place clean room in system Temp folder
To prevent DLL hijacking the clean room process when launched elevated,
the system Temp folder will be used instead of the user's temp folder.
This ensures the user cannot slip malicious DLLs into the clean room.

Fixes wixtoolset/issues#5724
@rseanhall

This comment has been minimized.

Show comment
Hide comment
@rseanhall

rseanhall Nov 15, 2017

Member

Looks good to me. At least this one is simple to fix.

Member

rseanhall commented Nov 15, 2017

Looks good to me. At least this one is simple to fix.

@barnson barnson merged commit c2b0b3f into wixtoolset:develop Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment