Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign binaries redistrubted with customers' bundles #481

Merged
merged 2 commits into from
Apr 8, 2019
Merged

Sign binaries redistrubted with customers' bundles #481

merged 2 commits into from
Apr 8, 2019

Conversation

heaths
Copy link
Contributor

@heaths heaths commented Mar 18, 2019 •
edited

Fixes wixtoolset/issues#5329. Only managed and native binaries that would ship within bundles are signed when requested.

@heaths
Sign binaries redistrubted with customers' bundles
f190d95 
Fixes #5329. Only managed and native binaries that would ship within bundles are signed when requested.
robmen
robmen requested changes Mar 18, 2019
View reviewed changes
Copy link
Member

@robmen robmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good. One open question...

src/ext/BalExtension/mba/core/core.csproj Outdated Show resolved Hide resolved
@heaths
Use ShouldSignObject in projects directly
64d1fbc 
Resolves feedback for issue #5329
@BMurri
Copy link
Contributor

BMurri commented Mar 29, 2019

Hey! I don't mean to stop the presses, but I don't see src/ext/ca/ in the list. Those absolutely end up in customer bundles (via the MSIs, to be sure, but...)

@heaths
Copy link
Contributor Author

heaths commented Mar 29, 2019

@BMurri, see https://github.com/wixtoolset/wix3/pull/481/files#diff-6ec57e3cf1fa4f7a7ba0393b4ec42679R51. All native projects under src/ext get signed.

@BMurri
Copy link
Contributor

BMurri commented Mar 29, 2019

@heaths /tools/appsettings.json affects /src/ext? The connection isn't obvious.

@heaths
Copy link
Contributor Author

heaths commented Mar 31, 2019

What? No, the WixBuild.vcxproj.props does, which is consistent with other WixBuild.*.props/targets and global per-project type settings.

@heaths
Copy link
Contributor Author

heaths commented Apr 5, 2019

Have you had a chance to try this with the new values you were given for real-signing? You can set them as environment variables (or command line properties) using the SignClientUser and SignClientSecret variables.

@robmen
Copy link
Member

robmen commented Apr 5, 2019

Completing this PR is the second thing on my list to do today. So, if it doesn't happen today, it'll be next.

@robmen robmen merged commit 64d1fbc into wixtoolset:develop Apr 8, 2019
robmen added a commit that referenced this pull request Apr 8, 2019
@robmen
Rebase pull request to close #481 from 'sign-everything'
80d831f
@heaths heaths deleted the issue5329 branch April 9, 2019 00:23
@appcodr appcodr mentioned this pull request Jan 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robmen robmen robmen approved these changes

@barnson barnson barnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@heaths @BMurri @robmen @barnson