-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all code to a class, add unit tests, handle multiple pages of milestones and labels #4
Conversation
Tested using |
@mnapoli Can you please review my work ? |
@williamdes I have been removed from this repository and I have no longer rights to maintain it. I don't know if this project is maintained, an option might be to use your own fork. |
Neither do I |
@anthHugo? |
We are waiting our CTO to know if we continue to maintain this repository :) |
app/data.php
Outdated
use GuzzleHttp\Client; | ||
use GuzzleHttp\Exception\ClientException; | ||
|
||
class data { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's follow a few principles here:
- uppercase names for classes
- separation of concerns
- useful constructors
I suggest splitting this class in 2, one for database write operations, and one for http fetch operations.
@williamdes thanks for your work on your PR. These are some very good improvements, but I think you can go a bit further 🚀 . |
Signed-off-by: William Desportes <williamdes@wdes.fr>
@wizacedric I improved this PR using some of your principles
I will maybe do some work on this |
@wizacedric Would you accept to merge this PR ? |
@wizagael can you please review my PR? |
cc @wizacedric .. |
github-to-mysql
intocomposer.json
binary section, see: 8a0980eTo review, you can review commit by commit