Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua type name resolution fails for API java classes #182

Closed
Adrodoc opened this issue May 11, 2018 · 0 comments
Closed

Lua type name resolution fails for API java classes #182

Adrodoc opened this issue May 11, 2018 · 0 comments
Assignees
@Adrodoc
Labels
bug

Comments

@Adrodoc
Copy link
Member

Adrodoc commented May 11, 2018

The lua type name resolution returns the qualified java class name for API java classes like BlockApi. This results in bad error messages when using an incorrect type for the first argument of an instance method.

Example:

spell.block.asItem(spell)

Prints:

Error during spell execution: net.wizardsoflua.lua.BadArgumentException: bad argument #1 (self) to 'asItem': expected net.wizardsoflua.lua.classes.block.BlockApi but got Spell
 at line 1 of command-line
@Adrodoc Adrodoc added the bug label May 11, 2018
@Adrodoc Adrodoc self-assigned this May 11, 2018
Adrodoc added a commit that referenced this issue May 11, 2018
@Adrodoc
Fix #182
d5e12e8
Adrodoc added a commit that referenced this issue May 11, 2018
@Adrodoc
Merge branch 'fix/#182' into devel
6f9d980
@Adrodoc Adrodoc mentioned this issue May 11, 2018
Merged
mkarneim added a commit that referenced this issue May 11, 2018
@mkarneim
Merge pull request #183 from wizards-of-lua/fix/#182
c6538d7 
Fix #182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adrodoc Adrodoc

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Adrodoc