Update rust-miniscript to 8.0.0
#67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird, the PSBT deserialization in rust-bitcoin became stricter. I'm chasing down the bug now. |
darosior
force-pushed
the
update_miniscript
branch
from
c18dd5f
to
a9b92df
Compare
|
Found it! We were missing some sighash type bytes at the end of some signatures in |
darosior
force-pushed
the
update_miniscript
branch
2 times, most recently
from
98804fa
to
27837a8
Compare
|
Alright. I don't want to take care of that now, it could well be an issue with an update of GA's |
darosior
force-pushed
the
update_miniscript
branch
from
dab2636
to
89818fa
Compare
This also updates the indirect rust-bitcoin dependency to 0.29. Major changes are in the descriptors management: - The rust-miniscript descriptors don't support raw hashes within the pk_h() fragments, so we don't need all the boutique management for this. - The key translator API changed. - We now take a u16 for the timelock instead of our previous checks. This was inspired by the new rust-bitcoin Sequence type. - We now take a path instead of just a derivation index in DerivedKey. We might use paths after all... As for rust-bitcoin it's just a few nits: - No more 'global' field on PSBTs (yay) - Couple more trait derivation on types - Some APIs were renamed.
darosior
force-pushed
the
update_miniscript
branch
from
89818fa
to
49ccc28
Compare
|
ACK 49ccc28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took the opportunity to update some dependencies, too.