Fix wrong resize anchor point #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when dragging the left border of a window with the mouse, there was a bug where it would snap the top level surface's geometry X coordinate directly to the position of the mouse, as if you started the resize right on the border. This also affected the other (right, bottom, and top) borders. I think that the previous resize code was hard to understand. Honestly I have not spent a lot of time trying to understand why t didn't work and I wrote another resize algorithm instead. Now instead of working directly with widths and heights which are complicated we work with the borders (left, right, top and bottom). This is easier to understand IMO.
ddevault
pushed a commit
to swaywm/wlroots
that referenced
this pull request
Apr 28, 2020
Previously, when dragging the left border of a window with the mouse in tinywl, there was a bug where it snap the top level surface's geometry X coordinate directly to the position of the mouse, as if you started the resize right on the border. This also affected the other (right, top and bottom) borders. I think that the previous resize code was hard to understand. Honestly I have not spent a lot of time trying to understand why it didn't work and I wrote another resize algorithm instead: now, instead of working directly with widths and heights which are complicated, we work with the borders (left, right, top, bottom). This is easier to understand IMO. Note: I originally fixed this [in the waybox compositor](wizbright/waybox#23) but then I realized that the code was taken from tinywl and that it had the same issues so I copied my fix for tinywl.
WillPower3309
pushed a commit
to wlrfx/scenefx
that referenced
this pull request
Jul 11, 2023
Previously, when dragging the left border of a window with the mouse in tinywl, there was a bug where it snap the top level surface's geometry X coordinate directly to the position of the mouse, as if you started the resize right on the border. This also affected the other (right, top and bottom) borders. I think that the previous resize code was hard to understand. Honestly I have not spent a lot of time trying to understand why it didn't work and I wrote another resize algorithm instead: now, instead of working directly with widths and heights which are complicated, we work with the borders (left, right, top, bottom). This is easier to understand IMO. Note: I originally fixed this [in the waybox compositor](wizbright/waybox#23) but then I realized that the code was taken from tinywl and that it had the same issues so I copied my fix for tinywl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when dragging the left border of a window with the mouse,
it would "ignore the anchor point" and set the window's position
directly to the position of the mouse. This also affected the other
(right, top and bottom) borders.
I think that the previous resize code was hard to understand. Honestly I
have not spent a lot of time trying to understand why I didn't work and
I wrote another resize algorithm instead.
Now, during a resize, we store the anchor point (drag_x and drag_y)
inside the window and we use it to change the left, right, top and
bottom values that represent the window's rectangle. This is easier to
understand IMO.