Dev angel coronado quintero final delivery #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataSource object removed. View Controller now implements data source now, and all logic goes into view model
Implementation of detail screen to MVVM
|
|
||
| import UIKit | ||
|
|
||
| class MovieDetailViewControllerMVVM: UIViewController, MovieDetailViewProtocol { |
There was a problem hiding this comment.
This should be final
| import UIKit | ||
|
|
||
| class MovieDetailViewControllerMVVM: UIViewController, MovieDetailViewProtocol { | ||
| var viewModel: MovieDetailViewModelProtocol? |
There was a problem hiding this comment.
This should be private
| viewModel?.fetchAllDetailData() | ||
| } | ||
|
|
||
| func bind() { |
There was a problem hiding this comment.
This should be private
Comment on lines
+48
to
+56
| self.title = viewModel?.getScreenTitle() | ||
| collectionView.collectionViewLayout = CompotitionalLayoutCreator.createLayoutForMovieDetail() | ||
| collectionView.setup(dataSource: self) | ||
| collectionView.setup(delegate: self) | ||
| collectionView.registerNibForCellWith(name: HeaderCollectionViewCell.identifierToDeque) | ||
| collectionView.registerNibForCellWith(name: MovieCollectionViewCell.identifierToDeque) | ||
| collectionView.reloadData() | ||
| let navigationItemReviews = UIBarButtonItem(image: UIImage(named: "reviews"), style: .plain, target: self, action: #selector(showReviewScreen)) | ||
| self.navigationItem.rightBarButtonItem = navigationItemReviews |
There was a problem hiding this comment.
You can make some functions with this
|
|
||
| } | ||
|
|
||
| @objc func showReviewScreen() { |
There was a problem hiding this comment.
This should be private
| } | ||
|
|
||
| @objc func showReviewScreen() { | ||
| print("show reviews") |
There was a problem hiding this comment.
This should be deleted
|
|
||
| extension MovieDetailViewControllerMVVM: UICollectionViewDataSource { | ||
| func numberOfSections(in collectionView: UICollectionView) -> Int { | ||
| return 2 |
There was a problem hiding this comment.
Try to avoid magic numbers
Comment on lines
+11
to
+33
| protocol MovieDetailViewModelProtocol { | ||
| var movie: MovieProtocol { get set } | ||
| var movieDetail: MovieDetailProtocol? { get set } | ||
| var similarMovies: MovieList? { get set } | ||
| var apiDataManager: MoviesDetailAPIDataManagerProtocol? { get set } | ||
| func fetchDetailWith(movie: MovieProtocol) | ||
| var didFetchMovieDetail: ((_ movieDetal: MovieDetailProtocol) -> Void )? { get set } | ||
| var didFailFetchingMovieDetail: ((_ error: Error) -> Void)? { get set } | ||
| func fetchSimiliarMoviesWith(movie: MovieProtocol) | ||
| var didFetchSimilarMovies: ((_ movies: MovieList) -> Void)? { get set } | ||
| var didFailFetchingSimilarMovies: ((_ error: Error) -> Void)? { get set } | ||
| func fetchAllDetailData() | ||
| func fetchDetail() | ||
| func fetchSimiliar() | ||
| var router: MoviesDetailRouterProtocol? { get set } | ||
| func showMovieDetailWith(movie: MovieProtocol, from view: UIViewController) | ||
| func showMovieReviews(view: UIViewController) | ||
| func getScreenTitle() -> String | ||
| } | ||
|
|
||
| protocol MovieDetailViewProtocol { | ||
| var viewModel: MovieDetailViewModelProtocol? { get set } | ||
| } |
There was a problem hiding this comment.
You can simplify this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Movie Detail screen with MVVM architecture.
Where should the reviewer start?
Movie Detail
Code review checklist Code Review Rubric
DRY Principle (Don’t repeat yourself)
Yagni Principle (You Aren't Gonna Need It)
KISS Principle (Keep It Simple, St...d)
Remove unused code
Hard-coded values
Language style guide & coding conventions
Wizeline Style Guide
RayWenderlich Style Guide
Architecture / Design Pattern
Architecture Implementation
SOLID
Single Responsibility Principle
Open Closed Principle
Liskov substitutability principle
Interface segregation
Dependency Inversion principle
Testing
Force unwrapping !
Mutable vs immutable property (Right use of
letandvar)Retain cycles (Capture list)
Code Documentation