This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
Estefania Jacobo #26
Open
Estefania Jacobo #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ederchrono
reviewed
Jan 14, 2019
| import "../styles/clouds-section.scss"; | ||
| import "../styles/newsletter-section.scss"; | ||
| import "../styles/footer.scss"; | ||
| import "../styles/responsive.scss"; |
There was a problem hiding this comment.
Nice way of separating the css rules
ederchrono
reviewed
Jan 14, 2019
|
|
||
| function modifyBlogData(currentBlog) { | ||
| var textSection = document.getElementsByClassName('blog-section__content-text'); | ||
| var titleText = textSection[0].getElementsByTagName('h1'); |
There was a problem hiding this comment.
Remember that selecting HTML nodes directly is not a good practice, using classes is preferred in case the site structure changes.
ederchrono
reviewed
Jan 14, 2019
| x[i].style.display = "block"; | ||
| } | ||
| var image = document.getElementsByClassName("blog-section__content-image"); | ||
| image[0].src = blogData.articles[currentBlog].images.desktop; |
There was a problem hiding this comment.
When you manage responsive images in this way you'll have problems when users don't have js turned on, I'd recommend to use HTML native responsive images instead https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Responsive_images
ederchrono
reviewed
Jan 14, 2019
| } | ||
| function displayCustomer(n) { | ||
| var i; | ||
| var x = document.getElementsByClassName("customers-section__images"); |
There was a problem hiding this comment.
Just as a recommendation, when selecting nodes with js is better to do it with selectors that are not related with styles and use a prefix, ie: .js-my-class-selector
ederchrono
approved these changes
Jan 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's your progress on the project?
Where should the reviewer start?
The responsive part was worked until the blog section.
Missing styling and most of the responsive design for tablet
Checklist
console.logs