New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly set html lang attribute #31

Merged

wiziple merged 1 commit into wiziple:versions/0.2.5 from olegshilov:fix/html_lang

Jun 24, 2019

Contributor

olegshilov commented Jun 21, 2019 •

edited

The right way to set html lang attribute in starter.
Because, as said here #28 pageContext prop is undefined inside Layout component.


          fix(starter): correctly set html lang attribute value from SEO component

cc83567

olegshilov mentioned this pull request

SEO Improvements #28

Closed

anicolaides commented Jun 21, 2019

It works!

Cheers @olegshilov!

wiziple merged commit 9c4ff49 into wiziple:versions/0.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment