feat(): exitgame block list for cores #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
changed the title
|
There is a logic error, SNES will include NES, so if you blocklist SNES you will also NES. |
|
My reader got super unstable, can't really test reliably |
asturur
commented
Feb 25, 2024
| } | ||
| return slices.Contains(blocklist, strings.ToLower(mister.GetActiveCoreName())) | ||
| } | ||
|
|
There was a problem hiding this comment.
should we do this at parsing time rather than everytime a card is removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a blocklist on the exit game functionality.
With an ini like this:
Tapto will exit the game when the card is removed, but not on NES and SNES core