-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix relative paths in python script #45
Conversation
Thanks! I'm able to run the script now, but I'm getting another error in the process of running:
The script is partially working, as I can see that a couple of the lyrics txt files have been changed. But I don't think all of them, as "The Black Dog" has not been changed, and that was the original example in #44. Any thoughts on what is causing the script to fail? |
Hmmm, do you have any binary files in the folders that contain the text files for the lyrics? The python script will start in the I made a new commit that changes the python script to only act on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice when committing, but it looks like I also converted some indentation from spaces to tabs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 237 240 +3
=========================================
+ Hits 237 240 +3 ☔ View full report in Codecov by Sentry. |
That worked! I was able to run the script and update all of the lyrics. I also added a step to my process when adding a new album to run the script so that hopefully this issue doesn't pop up again in the future. Thanks! Closes #44. |
This pull request fixes the relative path in the
fix-chars.py
python script, which should allow the python script to be ran by the following command