Compilation warning: "will be initialized after ..."

[nbigaouette]

Initialization in a constructor is out of order, resulting in a warning (ArchLinux x86_64, gcc version 4.8.2 20131219 (prerelease))

The warning is:

In file included from tools.cpp:4:
serial.h: In copy constructor 'serial::IOException::IOException(const serial::IOException&)':
serial.h:647:15: warning: 'serial::IOException::e_what_' will be initialized after [-Wreorder]
    std::string e_what_;
            ^
serial.h:646:7: warning:   'int serial::IOException::line_' [-Wreorder]
    int line_;
    ^
serial.h:671:3: warning:   when initialized here [-Wreorder]
    IOException (const IOException& other) : e_what_(other.e_what_), line_(other.line_), errno_(other.errno_) {}

[nbigaouette]

The warning can be fixed using this patch:

diff --git a/include/serial/serial.h b/include/serial/serial.h
index bf664c9..2a915d9 100644
--- a/include/serial/serial.h
+++ b/include/serial/serial.h
@@ -668,7 +668,7 @@ public:
       e_what_ = ss.str();
   }
   virtual ~IOException() throw() {}
-  IOException (const IOException& other) : e_what_(other.e_what_), line_(other.line_), errno_(other.errno_) {}
+  IOException (const IOException& other) : line_(other.line_), e_what_(other.e_what_), errno_(other.errno_) {}

   int getErrorNumber () { return errno_; }

[wjwwood]

@nbigaouette thanks for the contribution, I'll address this as soon as possible, but a pull request might get merged sooner.

[wjwwood]

Closing in favor of #54