Ensure local disk directory store does atomic put #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the directory storage provider did a write straight to final storage, which would result in a partial file if interrupted. Now we write to a tmpfile and do an atomic rename to the final location. On initialization of a directory store, the root directory is walked and any orphaned tmpfiles are deleted.
wkalt
force-pushed
the
task/fix-localdisk-atomic-storage
branch
from
927f87f
to
117ee7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the directory storage provider did a write straight to final storage, which would result in a partial file if interrupted. Now we write to a tmpfile and do an atomic rename to the final location.
On initialization of a directory store, the root directory is walked and any orphaned tmpfiles are deleted.