Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROIAlign for pytorch #10

Merged
merged 2 commits into from
Sep 17, 2018
Merged

Fix ROIAlign for pytorch #10

merged 2 commits into from
Sep 17, 2018

Conversation

merrymercy
Copy link
Contributor

@merrymercy merrymercy commented Sep 16, 2018

In mxnet, out.size is an integer.
In pytorch, out.size is a function that returns a tuple

@coveralls
Copy link

Pull Request Test Coverage Report for Build 199

  • 1 of 6 (16.67%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.3%) to 78.99%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mobula/op/custom/ROIAlign/ROIAlign.py 1 6 16.67%
Files with Coverage Reduction New Missed Lines %
mobula/test_utils.py 1 65.85%
mobula/glue/common.py 1 92.78%
mobula/op/load_module.py 4 94.57%
Totals Coverage Status
Change from base Build 198: 0.3%
Covered Lines: 985
Relevant Lines: 1247

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 16, 2018

Pull Request Test Coverage Report for Build 204

  • 2 of 7 (28.57%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.8%) to 79.471%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mobula/op/custom/ROIAlign/ROIAlign.py 2 7 28.57%
Files with Coverage Reduction New Missed Lines %
mobula/op/custom/ROIAlign/ROIAlign.py 1 50.0%
Totals Coverage Status
Change from base Build 203: 0.8%
Covered Lines: 991
Relevant Lines: 1247

💛 - Coveralls

@wkcn
Copy link
Owner

wkcn commented Sep 17, 2018

Thank you for your contribution!

@wkcn wkcn merged commit 1f97ae2 into wkcn:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants