Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in SoftmaxOp, compatible with MXNet 2.0, add custom Op C++ helper, refactor omp context #96

Closed
wants to merge 6 commits into from
Closed

Fix bug in SoftmaxOp, compatible with MXNet 2.0, add custom Op C++ helper, refactor omp context #96

wants to merge 6 commits into from

Conversation

wkcn
Copy link
Owner

@wkcn wkcn commented Jul 15, 2020 •
edited

In MXNet 2.0, mx.sym.simple_bind has been renamed to mx.sym._simple_bind.

  • compatible with MXNet 2.0
  • add CustomOp C++ helper
  • Fix bug in Softmax Op
  • refactor omp context

@wkcn wkcn force-pushed the compatible_with_mxnet2.0 branch from 1cc19bc to cc94f0c Compare July 15, 2020 13:32
@wkcn wkcn changed the title remove constant example and replace simple_bind with _simple_bind Fix bug in SoftmaxOp, compatible with MXNet 2.0, add custom Op C++ helper Jul 15, 2020
@coveralls
Copy link

coveralls commented Jul 15, 2020 •
edited

Pull Request Test Coverage Report for Build 828

  • 2 of 3 (66.67%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.0%) to 86.857%
Changes Missing Coverage Covered Lines Changed/Added Lines %
mobula/glue/mx.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
docs/tutorial/test_mul_op.py 2 84.15%
examples/MyFirstOP.py 2 76.79%
Totals Coverage Status
Change from base Build 818: 1.0%
Covered Lines: 1738
Relevant Lines: 2001
💛 - Coveralls

@wkcn wkcn changed the title Fix bug in SoftmaxOp, compatible with MXNet 2.0, add custom Op C++ helper Fix bug in SoftmaxOp, compatible with MXNet 2.0, add custom Op C++ helper, refactor omp context Jul 15, 2020
@wkcn wkcn closed this Jul 15, 2020
@wkcn wkcn reopened this Jul 15, 2020
@wkcn wkcn closed this Jul 15, 2020
@wkcn wkcn deleted the compatible_with_mxnet2.0 branch July 15, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkcn @coveralls