Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add a regex filename filter #310

Closed
wants to merge 5 commits into from

Conversation

o-laurent
Copy link
Contributor

@o-laurent o-laurent commented Jan 31, 2024

Hi @wkentaro,

I followed the directions that you provided in our discussion.

I remain available for any questions or updates.

This PR depends on #308.

@o-laurent o-laurent changed the title ✨ Add a regex filename filter Feature: Add a regex filename filter Jan 31, 2024
@o-laurent
Copy link
Contributor Author

o-laurent commented Jan 31, 2024

Another possibility would be to use something like https://docs.python.org/3/library/fnmatch.html that may be closer to what you expect of the behavior of a ".gitignore".

@wkentaro wkentaro self-assigned this Feb 1, 2024
@wkentaro wkentaro added the feature for pr label Feb 1, 2024
@wkentaro
Copy link
Owner

wkentaro commented Feb 1, 2024

@o-laurent Looking good, thanks. Btw, do you need the command line option?

@o-laurent
Copy link
Contributor Author

o-laurent commented Feb 1, 2024

@o-laurent Looking good, thanks. Btw, do you need the command line option?

@wkentaro, I won't need the CLI option. Of course, feel free to remove it if you think that your lib would be better without/it is not necessary.

By the way, I just pulled your changes from #308. This PR also fixes a lint issue.

@wkentaro
Copy link
Owner

wkentaro commented Feb 3, 2024

@o-laurent I think #317 is more simple yet flexible. Please check it out.

@wkentaro wkentaro closed this in #317 Feb 3, 2024
@o-laurent o-laurent deleted the filename-filter branch February 3, 2024 15:23
@o-laurent
Copy link
Contributor Author

Simpler, I'd say that it depends on the use case, but more flexible, definitely. It will solve my problem nicely. Thanks @wkentaro for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature for pr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants